Use `slf4j-simple` instead of `logback` that has a high chance of getting stuck in a deadlock on CI. by AlexeyKuznetsov-DD · Pull Request #10390 · DataDog/dd-trace-java

AlexeyKuznetsov-DD · 2026-01-15T23:29:26Z

What Does This Do

Use slf4j-simple instead of logback that has a high chance of getting stuck in a deadlock on CI.
We are using very old version of logback = "1.2.13" that is only version compatible with Java 8 and has a high chance to hang on CI on modern JVMs (usually 11).

Motivation

Green CI.

Additional Notes

With probability of 10% task is hanging on CI:

Execution failed for task ':dd-java-agent:instrumentation:vertx:vertx-web:vertx-web-3.4:test'.
> Timeout has been exceeded

With stack trace showing that it is hanging inside logback:

"Test worker" #1 prio=5 os_prio=0 cpu=8138.15ms elapsed=1144.47s tid=0x00007f172c02d000 nid=0x9c1d waiting on condition  [0x00007f17317f6000]
   java.lang.Thread.State: WAITING (parking)
	at jdk.internal.misc.Unsafe.park(java.base@11.0.29/Native Method)
	- parking to wait for  <0x00000000c0549728> (a java.util.concurrent.locks.ReentrantLock$NonfairSync)
	at java.util.concurrent.locks.LockSupport.park(java.base@11.0.29/LockSupport.java:194)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(java.base@11.0.29/AbstractQueuedSynchronizer.java:885)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(java.base@11.0.29/AbstractQueuedSynchronizer.java:917)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(java.base@11.0.29/AbstractQueuedSynchronizer.java:1240)
	at java.util.concurrent.locks.ReentrantLock.lock(java.base@11.0.29/ReentrantLock.java:267)
	at org.gradle.internal.remote.internal.hub.MessageHub$ChannelDispatch.dispatch(MessageHub.java:370)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:92)
	at com.sun.proxy.$Proxy5.output(Unknown Source)
	at org.gradle.api.internal.tasks.testing.redirector.TestOutputRedirector$Forwarder.onOutput(TestOutputRedirector.java:77)
	at org.gradle.api.internal.tasks.testing.redirector.DefaultStandardOutputRedirector$WriteAction.text(DefaultStandardOutputRedirector.java:85)
	at org.gradle.internal.io.LineBufferingOutputStream.flush(LineBufferingOutputStream.java:97)
	at org.gradle.internal.io.LineBufferingOutputStream.write(LineBufferingOutputStream.java:81)
	at java.io.OutputStream.write(java.base@11.0.29/OutputStream.java:157)
	at java.io.PrintStream.write(java.base@11.0.29/PrintStream.java:559)
	- locked <0x00000000c16dc970> (a java.io.PrintStream)
	at java.io.FilterOutputStream.write(java.base@11.0.29/FilterOutputStream.java:108)
	at org.gradle.internal.io.LinePerThreadBufferingOutputStream.write(LinePerThreadBufferingOutputStream.java:255)
	at ch.qos.logback.core.joran.spi.ConsoleTarget$1.write(ConsoleTarget.java:37)
	at ch.qos.logback.core.OutputStreamAppender.writeBytes(OutputStreamAppender.java:199)
	at ch.qos.logback.core.OutputStreamAppender.subAppend(OutputStreamAppender.java:231)
	at ch.qos.logback.core.OutputStreamAppender.append(OutputStreamAppender.java:102)
	at ch.qos.logback.core.UnsynchronizedAppenderBase.doAppend(UnsynchronizedAppenderBase.java:84)
	at ch.qos.logback.core.spi.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:51)
	at ch.qos.logback.classic.Logger.appendLoopOnAppenders(Logger.java:270)
	at ch.qos.logback.classic.Logger.callAppenders(Logger.java:257)
	at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:421)
	at ch.qos.logback.classic.Logger.filterAndLog_1(Logger.java:398)
	at ch.qos.logback.classic.Logger.debug(Logger.java:486)
	at datadog.trace.api.Config.<init>(Config.java:2982)
	at datadog.trace.api.Config.<init>(Config.java:1334)
	at datadog.trace.api.Config.<init>(Config.java:1330)

…ck in a deadlock on CI.

pr-commenter · 2026-01-16T00:10:31Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/vertx-web-3.4-tests-logger
git_commit_date	1768586118	1768603260
git_commit_sha	`189c0b6`	`f6a5422`
release_version	1.59.0-SNAPSHOT~189c0b6c76	1.59.0-SNAPSHOT~f6a54229fb

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1768606515	1768606515
ci_job_id	1357443284	1357443284
ci_pipeline_id	91212183	91212183
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-90qgty94 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-90qgty94 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~f6a54229fb, baseline=1.59.0-SNAPSHOT~189c0b6c76

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083920
Total [baseline] (8.776 s) : 0, 8776349
Agent [candidate] (1.086 s) : 0, 1086337
Total [candidate] (8.759 s) : 0, 8759052
section iast
Agent [baseline] (1.235 s) : 0, 1235394
Total [baseline] (9.377 s) : 0, 9376582
Agent [candidate] (1.223 s) : 0, 1222505
Total [candidate] (9.335 s) : 0, 9334708

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.084 s	-
Agent	iast	1.235 s	151.474 ms (14.0%)
Total	tracing	8.776 s	-
Total	iast	9.377 s	600.233 ms (6.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.086 s	-
Agent	iast	1.223 s	136.168 ms (12.5%)
Total	tracing	8.759 s	-
Total	iast	9.335 s	575.656 ms (6.6%)

gantt
    title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~f6a54229fb, baseline=1.59.0-SNAPSHOT~189c0b6c76

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (651.344 ms) : 0, 651344
BytebuddyAgent [candidate] (651.279 ms) : 0, 651279
GlobalTracer [baseline] (282.643 ms) : 0, 282643
GlobalTracer [candidate] (284.712 ms) : 0, 284712
AppSec [baseline] (32.634 ms) : 0, 32634
AppSec [candidate] (32.751 ms) : 0, 32751
Debugger [baseline] (67.208 ms) : 0, 67208
Debugger [candidate] (67.462 ms) : 0, 67462
Remote Config [baseline] (635.387 µs) : 0, 635
Remote Config [candidate] (633.781 µs) : 0, 634
Telemetry [baseline] (8.958 ms) : 0, 8958
Telemetry [candidate] (9.008 ms) : 0, 9008
Flare Poller [baseline] (3.834 ms) : 0, 3834
Flare Poller [candidate] (3.847 ms) : 0, 3847
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (799.653 ms) : 0, 799653
BytebuddyAgent [candidate] (791.372 ms) : 0, 791372
GlobalTracer [baseline] (258.528 ms) : 0, 258528
GlobalTracer [candidate] (256.146 ms) : 0, 256146
IAST [baseline] (27.306 ms) : 0, 27306
IAST [candidate] (26.797 ms) : 0, 26797
AppSec [baseline] (34.814 ms) : 0, 34814
AppSec [candidate] (33.867 ms) : 0, 33867
Debugger [baseline] (65.391 ms) : 0, 65391
Debugger [candidate] (65.13 ms) : 0, 65130
Remote Config [baseline] (570.784 µs) : 0, 571
Remote Config [candidate] (590.955 µs) : 0, 591
Telemetry [baseline] (8.475 ms) : 0, 8475
Telemetry [candidate] (8.477 ms) : 0, 8477
Flare Poller [baseline] (3.632 ms) : 0, 3632
Flare Poller [candidate] (3.57 ms) : 0, 3570

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~f6a54229fb, baseline=1.59.0-SNAPSHOT~189c0b6c76

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085625
Total [baseline] (10.783 s) : 0, 10782572
Agent [candidate] (1.09 s) : 0, 1089619
Total [candidate] (10.919 s) : 0, 10919090
section appsec
Agent [baseline] (1.265 s) : 0, 1264514
Total [baseline] (10.961 s) : 0, 10960764
Agent [candidate] (1.266 s) : 0, 1266129
Total [candidate] (10.995 s) : 0, 10995354
section iast
Agent [baseline] (1.227 s) : 0, 1226998
Total [baseline] (11.21 s) : 0, 11210290
Agent [candidate] (1.225 s) : 0, 1225397
Total [candidate] (11.227 s) : 0, 11226782
section profiling
Agent [baseline] (1.204 s) : 0, 1204038
Total [baseline] (10.883 s) : 0, 10883263
Agent [candidate] (1.204 s) : 0, 1204202
Total [candidate] (10.886 s) : 0, 10886167

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.086 s	-
Agent	appsec	1.265 s	178.889 ms (16.5%)
Agent	iast	1.227 s	141.373 ms (13.0%)
Agent	profiling	1.204 s	118.413 ms (10.9%)
Total	tracing	10.783 s	-
Total	appsec	10.961 s	178.192 ms (1.7%)
Total	iast	11.21 s	427.718 ms (4.0%)
Total	profiling	10.883 s	100.691 ms (0.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.09 s	-
Agent	appsec	1.266 s	176.51 ms (16.2%)
Agent	iast	1.225 s	135.778 ms (12.5%)
Agent	profiling	1.204 s	114.583 ms (10.5%)
Total	tracing	10.919 s	-
Total	appsec	10.995 s	76.264 ms (0.7%)
Total	iast	11.227 s	307.692 ms (2.8%)
Total	profiling	10.886 s	-32.922 ms (-0.3%)

gantt
    title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~f6a54229fb, baseline=1.59.0-SNAPSHOT~189c0b6c76

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (652.064 ms) : 0, 652064
BytebuddyAgent [candidate] (654.802 ms) : 0, 654802
GlobalTracer [baseline] (282.478 ms) : 0, 282478
GlobalTracer [candidate] (283.924 ms) : 0, 283924
AppSec [baseline] (32.676 ms) : 0, 32676
AppSec [candidate] (32.685 ms) : 0, 32685
Debugger [baseline] (68.228 ms) : 0, 68228
Debugger [candidate] (68.061 ms) : 0, 68061
Remote Config [baseline] (640.522 µs) : 0, 641
Remote Config [candidate] (628.35 µs) : 0, 628
Telemetry [baseline] (9.036 ms) : 0, 9036
Telemetry [candidate] (8.942 ms) : 0, 8942
Flare Poller [baseline] (3.786 ms) : 0, 3786
Flare Poller [candidate] (3.804 ms) : 0, 3804
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (691.658 ms) : 0, 691658
BytebuddyAgent [candidate] (691.144 ms) : 0, 691144
GlobalTracer [baseline] (258.293 ms) : 0, 258293
GlobalTracer [candidate] (258.732 ms) : 0, 258732
AppSec [baseline] (173.286 ms) : 0, 173286
AppSec [candidate] (174.208 ms) : 0, 174208
Debugger [baseline] (66.522 ms) : 0, 66522
Debugger [candidate] (66.874 ms) : 0, 66874
Remote Config [baseline] (729.831 µs) : 0, 730
Remote Config [candidate] (775.482 µs) : 0, 775
Telemetry [baseline] (9.286 ms) : 0, 9286
Telemetry [candidate] (9.341 ms) : 0, 9341
Flare Poller [baseline] (3.69 ms) : 0, 3690
Flare Poller [candidate] (3.801 ms) : 0, 3801
IAST [baseline] (24.47 ms) : 0, 24470
IAST [candidate] (24.651 ms) : 0, 24651
section iast
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (793.158 ms) : 0, 793158
BytebuddyAgent [candidate] (792.267 ms) : 0, 792267
GlobalTracer [baseline] (256.877 ms) : 0, 256877
GlobalTracer [candidate] (256.805 ms) : 0, 256805
AppSec [baseline] (35.255 ms) : 0, 35255
AppSec [candidate] (34.539 ms) : 0, 34539
Debugger [baseline] (65.35 ms) : 0, 65350
Debugger [candidate] (65.489 ms) : 0, 65489
Remote Config [baseline] (594.197 µs) : 0, 594
Remote Config [candidate] (579.91 µs) : 0, 580
Telemetry [baseline] (8.536 ms) : 0, 8536
Telemetry [candidate] (8.457 ms) : 0, 8457
Flare Poller [baseline] (3.569 ms) : 0, 3569
Flare Poller [candidate] (3.531 ms) : 0, 3531
IAST [baseline] (27.056 ms) : 0, 27056
IAST [candidate] (27.141 ms) : 0, 27141
section profiling
ProfilingAgent [baseline] (96.486 ms) : 0, 96486
ProfilingAgent [candidate] (97.234 ms) : 0, 97234
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.235 ms) : 0, 1235
BytebuddyAgent [baseline] (701.777 ms) : 0, 701777
BytebuddyAgent [candidate] (701.844 ms) : 0, 701844
GlobalTracer [baseline] (220.978 ms) : 0, 220978
GlobalTracer [candidate] (220.676 ms) : 0, 220676
AppSec [baseline] (32.106 ms) : 0, 32106
AppSec [candidate] (32.016 ms) : 0, 32016
Debugger [baseline] (68.338 ms) : 0, 68338
Debugger [candidate] (68.189 ms) : 0, 68189
Remote Config [baseline] (664.721 µs) : 0, 665
Remote Config [candidate] (609.833 µs) : 0, 610
Telemetry [baseline] (8.961 ms) : 0, 8961
Telemetry [candidate] (8.836 ms) : 0, 8836
Flare Poller [baseline] (3.768 ms) : 0, 3768
Flare Poller [candidate] (3.711 ms) : 0, 3711
Profiling [baseline] (97.068 ms) : 0, 97068
Profiling [candidate] (97.818 ms) : 0, 97818

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/vertx-web-3.4-tests-logger
git_commit_date	1768586118	1768603260
git_commit_sha	`189c0b6`	`f6a5422`
release_version	1.59.0-SNAPSHOT~189c0b6c76	1.59.0-SNAPSHOT~f6a54229fb

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1768607006	1768607006
ci_job_id	1357443285	1357443285
ci_pipeline_id	91212183	91212183
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-7dzk4s6w 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-7dzk4s6w 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	better [-191.982µs; -95.394µs] or [-6.506%; -3.233%]	unsure [-538.148µs; -164.667µs] or [-6.531%; -1.998%]	unstable [-72.370op/s; +169.120op/s] or [-5.837%; +13.640%]	2.807ms	7.889ms	1288.219op/s	2.951ms	8.240ms	1239.844op/s
scenario:load:petclinic:appsec:high_load	better [-1.512ms; -0.510ms] or [-7.759%; -2.618%]	unsure [-2.413ms; -0.280ms] or [-7.700%; -0.894%]	unstable [-16.895op/s; +41.082op/s] or [-7.163%; +17.419%]	18.480ms	29.992ms	247.938op/s	19.492ms	31.339ms	235.844op/s
scenario:load:petclinic:no_agent:high_load	worse [+1.042ms; +2.554ms] or [+5.947%; +14.574%]	unstable [+0.515ms; +4.064ms] or [+1.773%; +13.989%]	unstable [-55.341op/s; +6.841op/s] or [-21.186%; +2.619%]	19.320ms	31.339ms	236.969op/s	17.522ms	29.049ms	261.219op/s
scenario:load:petclinic:profiling:high_load	better [-1393.963µs; -510.770µs] or [-7.111%; -2.606%]	unsure [-2.022ms; -0.022ms] or [-6.561%; -0.070%]	unstable [-17.594op/s; +39.594op/s] or [-7.470%; +16.810%]	18.651ms	29.794ms	246.531op/s	19.603ms	30.815ms	235.531op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~f6a54229fb, baseline=1.59.0-SNAPSHOT~189c0b6c76
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.182 ms) : 1171, 1194
.   : milestone, 1182,
iast (3.237 ms) : 3194, 3281
.   : milestone, 3237,
iast_FULL (5.865 ms) : 5806, 5923
.   : milestone, 5865,
iast_GLOBAL (3.702 ms) : 3647, 3757
.   : milestone, 3702,
profiling (1.988 ms) : 1969, 2008
.   : milestone, 1988,
tracing (1.796 ms) : 1781, 1811
.   : milestone, 1796,
section candidate
no_agent (1.187 ms) : 1176, 1199
.   : milestone, 1187,
iast (3.133 ms) : 3096, 3171
.   : milestone, 3133,
iast_FULL (5.927 ms) : 5867, 5986
.   : milestone, 5927,
iast_GLOBAL (3.56 ms) : 3508, 3612
.   : milestone, 3560,
profiling (1.951 ms) : 1935, 1968
.   : milestone, 1951,
tracing (1.77 ms) : 1755, 1785
.   : milestone, 1770,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.182 ms [1.171 ms, 1.194 ms]	-
iast	3.237 ms [3.194 ms, 3.281 ms]	2.055 ms (173.8%)
iast_FULL	5.865 ms [5.806 ms, 5.923 ms]	4.682 ms (396.0%)
iast_GLOBAL	3.702 ms [3.647 ms, 3.757 ms]	2.519 ms (213.1%)
profiling	1.988 ms [1.969 ms, 2.008 ms]	805.772 µs (68.1%)
tracing	1.796 ms [1.781 ms, 1.811 ms]	613.585 µs (51.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.187 ms [1.176 ms, 1.199 ms]	-
iast	3.133 ms [3.096 ms, 3.171 ms]	1.946 ms (163.9%)
iast_FULL	5.927 ms [5.867 ms, 5.986 ms]	4.739 ms (399.1%)
iast_GLOBAL	3.56 ms [3.508 ms, 3.612 ms]	2.373 ms (199.8%)
profiling	1.951 ms [1.935 ms, 1.968 ms]	763.913 µs (64.3%)
tracing	1.77 ms [1.755 ms, 1.785 ms]	582.432 µs (49.1%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~f6a54229fb, baseline=1.59.0-SNAPSHOT~189c0b6c76
    dateFormat X
    axisFormat %s
section baseline
no_agent (17.867 ms) : 17682, 18051
.   : milestone, 17867,
appsec (19.796 ms) : 19594, 19997
.   : milestone, 19796,
code_origins (17.746 ms) : 17571, 17921
.   : milestone, 17746,
iast (17.843 ms) : 17664, 18021
.   : milestone, 17843,
profiling (19.822 ms) : 19624, 20020
.   : milestone, 19822,
tracing (17.615 ms) : 17437, 17792
.   : milestone, 17615,
section candidate
no_agent (19.7 ms) : 19495, 19906
.   : milestone, 19700,
appsec (18.829 ms) : 18635, 19023
.   : milestone, 18829,
code_origins (17.736 ms) : 17557, 17914
.   : milestone, 17736,
iast (17.794 ms) : 17616, 17973
.   : milestone, 17794,
profiling (18.933 ms) : 18744, 19122
.   : milestone, 18933,
tracing (17.675 ms) : 17498, 17852
.   : milestone, 17675,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	17.867 ms [17.682 ms, 18.051 ms]	-
appsec	19.796 ms [19.594 ms, 19.997 ms]	1.929 ms (10.8%)
code_origins	17.746 ms [17.571 ms, 17.921 ms]	-121.019 µs (-0.7%)
iast	17.843 ms [17.664 ms, 18.021 ms]	-24.001 µs (-0.1%)
profiling	19.822 ms [19.624 ms, 20.02 ms]	1.956 ms (10.9%)
tracing	17.615 ms [17.437 ms, 17.792 ms]	-252.224 µs (-1.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.7 ms [19.495 ms, 19.906 ms]	-
appsec	18.829 ms [18.635 ms, 19.023 ms]	-871.272 µs (-4.4%)
code_origins	17.736 ms [17.557 ms, 17.914 ms]	-1.965 ms (-10.0%)
iast	17.794 ms [17.616 ms, 17.973 ms]	-1.906 ms (-9.7%)
profiling	18.933 ms [18.744 ms, 19.122 ms]	-766.846 µs (-3.9%)
tracing	17.675 ms [17.498 ms, 17.852 ms]	-2.025 ms (-10.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/vertx-web-3.4-tests-logger
git_commit_date	1768586118	1768603260
git_commit_sha	`189c0b6`	`f6a5422`
release_version	1.59.0-SNAPSHOT~189c0b6c76	1.59.0-SNAPSHOT~f6a54229fb

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1768606719	1768606719
ci_job_id	1357443286	1357443286
ci_pipeline_id	91212183	91212183
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-xaa8eku1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-xaa8eku1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~f6a54229fb, baseline=1.59.0-SNAPSHOT~189c0b6c76
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.01 s) : 15010000, 15010000
.   : milestone, 15010000,
appsec (15.036 s) : 15036000, 15036000
.   : milestone, 15036000,
iast (17.962 s) : 17962000, 17962000
.   : milestone, 17962000,
iast_GLOBAL (17.868 s) : 17868000, 17868000
.   : milestone, 17868000,
profiling (15.185 s) : 15185000, 15185000
.   : milestone, 15185000,
tracing (14.837 s) : 14837000, 14837000
.   : milestone, 14837000,
section candidate
no_agent (15.554 s) : 15554000, 15554000
.   : milestone, 15554000,
appsec (14.634 s) : 14634000, 14634000
.   : milestone, 14634000,
iast (18.111 s) : 18111000, 18111000
.   : milestone, 18111000,
iast_GLOBAL (17.705 s) : 17705000, 17705000
.   : milestone, 17705000,
profiling (14.791 s) : 14791000, 14791000
.   : milestone, 14791000,
tracing (14.668 s) : 14668000, 14668000
.   : milestone, 14668000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.01 s [15.01 s, 15.01 s]	-
appsec	15.036 s [15.036 s, 15.036 s]	26.0 ms (0.2%)
iast	17.962 s [17.962 s, 17.962 s]	2.952 s (19.7%)
iast_GLOBAL	17.868 s [17.868 s, 17.868 s]	2.858 s (19.0%)
profiling	15.185 s [15.185 s, 15.185 s]	175.0 ms (1.2%)
tracing	14.837 s [14.837 s, 14.837 s]	-173.0 ms (-1.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.554 s [15.554 s, 15.554 s]	-
appsec	14.634 s [14.634 s, 14.634 s]	-920.0 ms (-5.9%)
iast	18.111 s [18.111 s, 18.111 s]	2.557 s (16.4%)
iast_GLOBAL	17.705 s [17.705 s, 17.705 s]	2.151 s (13.8%)
profiling	14.791 s [14.791 s, 14.791 s]	-763.0 ms (-4.9%)
tracing	14.668 s [14.668 s, 14.668 s]	-886.0 ms (-5.7%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~f6a54229fb, baseline=1.59.0-SNAPSHOT~189c0b6c76
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (3.63 ms) : 3415, 3846
.   : milestone, 3630,
iast (2.217 ms) : 2152, 2283
.   : milestone, 2217,
iast_GLOBAL (2.259 ms) : 2193, 2324
.   : milestone, 2259,
profiling (2.067 ms) : 2013, 2121
.   : milestone, 2067,
tracing (2.051 ms) : 2000, 2103
.   : milestone, 2051,
section candidate
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (3.689 ms) : 3470, 3908
.   : milestone, 3689,
iast (2.209 ms) : 2144, 2275
.   : milestone, 2209,
iast_GLOBAL (2.254 ms) : 2188, 2320
.   : milestone, 2254,
profiling (2.07 ms) : 2017, 2123
.   : milestone, 2070,
tracing (2.044 ms) : 1992, 2096
.   : milestone, 2044,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	3.63 ms [3.415 ms, 3.846 ms]	2.159 ms (146.7%)
iast	2.217 ms [2.152 ms, 2.283 ms]	745.926 µs (50.7%)
iast_GLOBAL	2.259 ms [2.193 ms, 2.324 ms]	787.019 µs (53.5%)
profiling	2.067 ms [2.013 ms, 2.121 ms]	595.784 µs (40.5%)
tracing	2.051 ms [2.0 ms, 2.103 ms]	579.954 µs (39.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.456 ms, 1.479 ms]	-
appsec	3.689 ms [3.47 ms, 3.908 ms]	2.221 ms (151.4%)
iast	2.209 ms [2.144 ms, 2.275 ms]	741.837 µs (50.6%)
iast_GLOBAL	2.254 ms [2.188 ms, 2.32 ms]	786.387 µs (53.6%)
profiling	2.07 ms [2.017 ms, 2.123 ms]	602.132 µs (41.0%)
tracing	2.044 ms [1.992 ms, 2.096 ms]	576.571 µs (39.3%)

bric3

THis is ok for me, but I'll wait on IAST folk to approve there

bric3 · 2026-01-16T09:24:49Z

internal-api/src/main/java/datadog/trace/api/iast/Taintable.java

+
+      // Check logger class by name to avoid NoClassDefFoundError at runtime for tests without
+      // Logback.
+      if (LOGGER.getClass().getName().equals("ch.qos.logback.classic.Logger")) {


question: Mostly to IAST folk, does it makes sense to support additional loggers ?

E.g. https://github.com/qos-ch/slf4j/blob/master/slf4j-simple/src/main/java/org/slf4j/simple/SimpleLogger.java

Same for https://github.com/DataDog/dd-trace-java/pull/10390/changes#diff-3184e5348b8ced794d3398d54e5feb997c7fad5967ad52f64cafd53526263c41R83

Since Taintable.DebugLogger is only used internally in tests (activated via TaintableVisitor.DEBUG = true) and not exposed to end users, we only need it to work with whatever logger is present in our test suite

dd-trace-java/dd-java-agent/agent-iast/iast-test-fixtures/src/main/groovy/com/datadog/iast/test/IastHttpServerTest.groovy

Line 43 in 5c6f495

TaintableVisitor.DEBUG = true

mcculls

LGTM, just needs a review from IAST before merging

jandro996

LGTM!

AlexeyKuznetsov-DD added 2 commits January 15, 2026 17:23

Use slf4j-simple as default; logback has a high chance of getting stu…

ec2b7ec

…ck in a deadlock on CI.

Relaxed checks for Logback.

00d4a72

AlexeyKuznetsov-DD requested review from bric3 and mcculls January 15, 2026 23:29

AlexeyKuznetsov-DD self-assigned this Jan 15, 2026

AlexeyKuznetsov-DD added comp: testing Testing tag: no release notes Changes to exclude from release notes inst: vertx Eclipse Vert.x instrumentation labels Jan 15, 2026

AlexeyKuznetsov-DD marked this pull request as ready for review January 15, 2026 23:31

AlexeyKuznetsov-DD requested review from a team as code owners January 15, 2026 23:31

AlexeyKuznetsov-DD requested review from daniel-romano-DD and jandro996 January 15, 2026 23:31

bric3 approved these changes Jan 16, 2026

View reviewed changes

AlexeyKuznetsov-DD marked this pull request as draft January 16, 2026 16:34

AlexeyKuznetsov-DD added the tag: do not merge Do not merge changes label Jan 16, 2026

AlexeyKuznetsov-DD marked this pull request as ready for review January 16, 2026 22:32

AlexeyKuznetsov-DD removed the tag: do not merge Do not merge changes label Jan 16, 2026

AlexeyKuznetsov-DD requested review from cataphract and manuel-alvarez-alvarez January 16, 2026 22:37

AlexeyKuznetsov-DD added 2 commits January 16, 2026 17:40

Merge branch 'master' into alexeyk/vertx-web-3.4-tests-logger

e141dcb

Minor.

f6a5422

mcculls approved these changes Jan 20, 2026

View reviewed changes

amarziali approved these changes Jan 28, 2026

View reviewed changes

jandro996 approved these changes Feb 2, 2026

View reviewed changes

jandro996 merged commit e7dbc55 into master Feb 2, 2026
566 checks passed

jandro996 deleted the alexeyk/vertx-web-3.4-tests-logger branch February 2, 2026 12:04

github-actions bot added this to the 1.59.0 milestone Feb 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `slf4j-simple` instead of `logback` that has a high chance of getting stuck in a deadlock on CI.#10390

Use `slf4j-simple` instead of `logback` that has a high chance of getting stuck in a deadlock on CI.#10390
jandro996 merged 4 commits intomasterfrom
alexeyk/vertx-web-3.4-tests-logger

AlexeyKuznetsov-DD commented Jan 15, 2026 •

edited

Loading

Uh oh!

pr-commenter bot commented Jan 16, 2026 •

edited

Loading

Uh oh!

bric3 left a comment

Uh oh!

bric3 Jan 16, 2026

Uh oh!

jandro996 Feb 2, 2026

Uh oh!

mcculls left a comment

Uh oh!

jandro996 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

AlexeyKuznetsov-DD commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Uh oh!

pr-commenter bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

bric3 left a comment

Choose a reason for hiding this comment

Uh oh!

bric3 Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

jandro996 Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

mcculls left a comment

Choose a reason for hiding this comment

Uh oh!

jandro996 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

AlexeyKuznetsov-DD commented Jan 15, 2026 •

edited

Loading

pr-commenter bot commented Jan 16, 2026 •

edited

Loading